Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: masked item are not available #2015

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Jun 9, 2021

Masked items must be considerate as not available for circulation
operation and public view.

Co-Authored-by: Renaud Michotte [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai requested a review from BadrAly June 9, 2021 14:30
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Jun 9, 2021
@zannkukai zannkukai self-assigned this Jun 9, 2021
@zannkukai zannkukai requested a review from jma June 9, 2021 14:31
@zannkukai zannkukai added this to the v1.3.0 milestone Jun 9, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

rero_ils/modules/items/api/circulation.py Outdated Show resolved Hide resolved
Masked items must be considerate as not available for circulation
operation and public view.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai merged commit 47e12d9 into rero:dev Jun 11, 2021
@zannkukai zannkukai deleted the zan-masked-item branch June 11, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants